Add test for lsp_add_on flag in CLI
#2101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
changed the title
lsp_add-on flag in CLIlsp_add_on flag in CLI
andyw8
force-pushed
the
andyw8/add-test-for-lsp-addon-flag-in-cli
branch
from
f665339 to
dd9aaad
Compare
andyw8
force-pushed
the
andyw8/add-test-for-lsp-addon-flag-in-cli
branch
from
dd9aaad to
ffc509c
Compare
|
(I can split off the Mocha setup into a seperate PR if desired) |
vinistock
reviewed
Nov 29, 2024
spec/tapioca/cli_spec.rb
Outdated
| class CliSpec < SpecWithProject | ||
| describe "Tapioca::Cli" do | ||
| before do | ||
| @command_stub = mock(run: nil) |
There was a problem hiding this comment.
This is just my preference, but I would avoid the extra dependency and just use Minitest::Mock here. I don't know what's the opinion for the rest of the team
|
As suggested by @Morriar, I'm going to try using a single spec for all the LSP behavior. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Part of https://github.com/Shopify/team-ruby-dx/issues/1327
Implementation
Until now, most of Tapioca tests have been integration tests. Trying to verify the new LSP behaviour using this approach will be difficult, so I suggest we should consider a more mockist-style approach.
I'm choosing to use Mocha as it's the standard for Shopify, and it allows a lot flexibility.
I intend to add some integration tests later to verify the LSP behaviour as a whole
TODO:
Tests
Indeed.